Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply missing coments from PR#1212 #1240

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

r0x0d
Copy link
Member

@r0x0d r0x0d commented May 23, 2024

The following comments are applied in this patch:

Jira Issues:

Checklist

  • PR has been tested manually in a VM (either author or reviewer)
  • Jira issue has been made public if possible
  • [RHELC-] is part of the PR title
  • GitHub label has been added to help with Release notes
  • PR title explains the change from the user's point of view
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending if relevant

@r0x0d r0x0d added the skip/changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc. label May 23, 2024
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.75%. Comparing base (f96179b) to head (d7c7937).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1240   +/-   ##
=======================================
  Coverage   95.74%   95.75%           
=======================================
  Files          55       55           
  Lines        4752     4756    +4     
  Branches      834      835    +1     
=======================================
+ Hits         4550     4554    +4     
  Misses        116      116           
  Partials       86       86           
Flag Coverage Δ
centos-linux-7 90.93% <100.00%> (+<0.01%) ⬆️
centos-linux-8 91.87% <100.00%> (+<0.01%) ⬆️
centos-linux-9 91.91% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hosekadam hosekadam added the tests/tier0 PR ready to run the essential test suit. Equivalent to `/packit test --labels tier0`. label May 23, 2024
@has-bot
Copy link
Member

has-bot commented May 23, 2024

/packit test --labels tier0


Comment generated by an automation.

@r0x0d r0x0d force-pushed the apply-comments-from-sub-man-pr branch from 5aaa2ee to d7c7937 Compare May 31, 2024 14:55
@Venefilyn Venefilyn merged commit 9f75793 into oamg:main Jun 13, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc. tests/tier0 PR ready to run the essential test suit. Equivalent to `/packit test --labels tier0`.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants