[RHELC-1547] Fix regression in installing removed packages during rollback #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0x0d
added
kind/bug-fix
We were passing a set object to iterate over to compose a message of packages that got removed during yum transaction. This problem was not happening before as we were dealing with a success case of restoring packages. In this regression, we found out that a set object does not have indexing, therefore, thus bug was hidden from most of our tests and pipeline.
r0x0d
force-pushed
the
fix-set-object-without-indexing
branch
from
3f00544 to
5344d81
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1226 +/- ##
=======================================
Coverage 95.42% 95.42%
=======================================
Files 54 54
Lines 4699 4699
Branches 829 829
=======================================
Hits 4484 4484
Misses 132 132
Partials 83 83
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/packit test --labels tier0 |
danmyway
approved these changes
May 17, 2024
There was a problem hiding this comment.
That looks good to me, tests are passing, the package is getting restored correctly.
Thanks, @r0x0d !
@Venefilyn could you please take a quick look, we can merge from my POV.
hosekadam
reviewed
May 17, 2024
hosekadam
approved these changes
May 17, 2024
Co-authored-by: Adam Hosek <hosek.adam@outlook.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were passing a set object to iterate over to compose a message of packages that got removed during yum transaction. This problem was not happening before as we were dealing with a success case of restoring packages. In this regression, we found out that a set object does not have indexing, therefore, thus bug was hidden from most of our tests and pipeline.
Jira Issues:
Checklist
[RHELC-]is part of the PR titleRelease Pendingif relevant