[RHELC-1532] Require username and password to be specified #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We didn't require username and password to be specified when one was provided but not the other. Such as username being provided but without a password, or vice versa. Due to that convert2rhel fails much later in the process than other warnings. This addresses that with warning messages and aligns with other cases like activation_key and org
Venefilyn
force-pushed
the
fix/userpass-without-one-half
branch
from
0e9d5cc to
2ec5a8c
Compare
r0x0d
approved these changes
May 6, 2024
Venefilyn
changed the title
Venefilyn
added
tests/sanity
|
Codecov is misbehaving again. I'm merging this as the sanity tests are all green and the results from the unit tests doesn't include any errors. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't require username and password to be specified when one was
provided but not the other. Such as username being provided but without
a password, or vice versa. Due to that convert2rhel fails much later
in the process than other warnings.
This addresses that with warning messages and aligns with other cases
like activation_key and org
Jira Issues:
Checklist
[RHELC-]is part of the PR titleRelease Pendingif relevant