[RHELC-1164] Update RHSM custom facts during analysis #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1043 +/- ##
==========================================
- Coverage 95.30% 95.28% -0.02%
==========================================
Files 51 51
Lines 4645 4649 +4
Branches 822 824 +2
==========================================
+ Hits 4427 4430 +3
Misses 139 139
- Partials 79 80 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pr-watson
reviewed
Jan 26, 2024
pr-watson
reviewed
Jan 26, 2024
pr-watson
approved these changes
Jan 26, 2024
r0x0d
added
the
tests/tier0
r0x0d
force-pushed
the
analysis-facts-collection
branch
from
ecf3514 to
51567ea
Compare
r0x0d
force-pushed
the
analysis-facts-collection
branch
from
51567ea to
d59cadf
Compare
|
/packit test --labels tier0 |
hosekadam
reviewed
Feb 15, 2024
hosekadam
reviewed
Feb 15, 2024
hosekadam
reviewed
Feb 15, 2024
r0x0d
force-pushed
the
analysis-facts-collection
branch
from
a5c85de to
4f4f2e1
Compare
|
/packit test --labels tier0 |
|
/packit test --labels tier0 |
hosekadam
approved these changes
Feb 19, 2024
|
/packit test --labels tier0 |
r0x0d
force-pushed
the
analysis-facts-collection
branch
2 times, most recently
from
a01b849 to
ca9ad24
Compare
|
/packit test --labels tier0 |
1 similar comment
|
/packit test --labels tier0 |
r0x0d
force-pushed
the
analysis-facts-collection
branch
from
ca9ad24 to
86b8df6
Compare
Enable the RHSM custom facts update during analysis mode. The update will only happen if the system was registered before, otherwise, we won't do nothing Signed-off-by: Rodolfo Olivieri <rolivier@redhat.com>
Signed-off-by: Rodolfo Olivieri <rolivier@redhat.com>
Signed-off-by: Rodolfo Olivieri <rolivier@redhat.com>
Co-authored-by: Adam Hosek <hosek.adam@outlook.com>
r0x0d
force-pushed
the
analysis-facts-collection
branch
from
86b8df6 to
00f3bbd
Compare
|
/packit test --labels tier0 |
r0x0d
force-pushed
the
analysis-facts-collection
branch
from
00f3bbd to
ed58914
Compare
|
/packit test --labels tier0 |
1 similar comment
|
/packit test --labels tier0 |
r0x0d
force-pushed
the
analysis-facts-collection
branch
from
ed58914 to
7e8a982
Compare
|
/packit test --labels tier0 |
danmyway
approved these changes
Mar 7, 2024
Comment on lines
+8
to
+12
| summary+: | | ||
| RHSM facts update after analysis | ||
| description+: | | ||
| This test verifies that the RHSM facts are uploaded when running | ||
| convert2rhel with analysis option. |
There was a problem hiding this comment.
This is just duplicating the summary and description from the root of the path in the file.
Could be consolidated, I wouldn't block the merge on this though.
| pytest -svv -m test_rhsm_facts_called_in_analysis | ||
| adjust+: | ||
| - enabled: false | ||
| when: distro == oracle-7, oracle-8 |
There was a problem hiding this comment.
Suggested change
| when: distro == oracle-7, oracle-8 | |
| when: distro == oracle |
The filtering calls the startswith() method, I believe, so no need to include both.
Again not a blocker, will fix in a different PR.
jochapma
pushed a commit
to jochapma/convert2rhel
that referenced
this pull request
Mar 11, 2024
* Update RHSM custom facts during analysis Enable the RHSM custom facts update during analysis mode. The update will only happen if the system was registered before, otherwise, we won't do nothing Signed-off-by: Rodolfo Olivieri <rolivier@redhat.com> * Fix failling main test Signed-off-by: Rodolfo Olivieri <rolivier@redhat.com> * Add integration tests Signed-off-by: Rodolfo Olivieri <rolivier@redhat.com> * Apply suggestions from code review Co-authored-by: Adam Hosek <hosek.adam@outlook.com> * Update integration tests --------- Signed-off-by: Rodolfo Olivieri <rolivier@redhat.com> Co-authored-by: Adam Hosek <hosek.adam@outlook.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the RHSM custom facts update during analysis mode.
The update will only happen if the system was registered before, otherwise, we won't do nothing
Jira Issues: RHELC-1164
Checklist
[RHELC-]is part of the PR titleRelease Pendingif relevant