This repository has been archived by the owner on Sep 4, 2020. It is now read-only.
Only create PVC when a matching volume is found #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
What's the reason for this change? |
|
the change tries to find a matched volume before calls creation on a PVC parsed out of an app cfg, to avoid unused objects being created behind the scene |
wonderflow
reviewed
Feb 1, 2020
| fn find_volume(&self) -> Option<&Volume> { | ||
| self.component.containers.iter().find_map(|c| { | ||
| c.resources.volumes.as_ref().and_then(|vols| { | ||
| vols.iter() | ||
| .filter(|v| !v.disk.as_ref().unwrap().ephemeral) |
There was a problem hiding this comment.
Does it mean if we create a new PV, it's not ephemeral?
There was a problem hiding this comment.
That's the plan, so we won't create a PVC for a ephemeral volume. Does it make sense.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#522