Skip to content
This repository has been archived by the owner on Sep 4, 2020. It is now read-only.

add k8s event record for rudr controller #473

Merged
merged 2 commits into from
Dec 10, 2019
Merged

Conversation

wonderflow
Copy link
Member

@wonderflow wonderflow commented Nov 20, 2019

fixes #316

This is a good start for rudr to add every important stage into kubenetes event. Then we could see the events from kubectl describe like below:

$ kubectl describe cfg first-app
Name:         first-app
Kind:         ApplicationConfiguration
...
Spec:
  Components:
    Component Name:  helloworld-python-v1
    Instance Name:   first-app-helloworld-python-v1
...
Events:
  Type     Reason                                                                                     Age   From  Message
  ----     ------                                                                                     ----  ----  -------
  Warning  ApiError NotFound ("componentschematics.core.oam.dev \"helloworld-python-v1\" not found")  3s          creating AppConfig first-app error
$ kubectl describe cfg first-app
Name:         first-app
Kind:         ApplicationConfiguration
..
Events:
  Type    Reason  Age   From  Message
  ----    ------  ----  ----  -------
  Normal          41s         component helloworld-python-v1 created

@wonderflow wonderflow changed the title add k8s event for instigator add k8s event record for rudr controller Nov 20, 2019
Copy link
Member

@hongchaodeng hongchaodeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@suhuruli suhuruli merged commit 335de10 into oam-dev:master Dec 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add K8s events to AppConfig CR
3 participants