This repository has been archived by the owner on May 14, 2021. It is now read-only.
block the volume-mounter to apply on ephemeral volume #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hongchaodeng
reviewed
Feb 6, 2020
pkg/admit/appconfig.go
Outdated
| for _, c := range comp.Spec.Containers { | ||
| for _, v := range c.Resources.Volumes { | ||
| //TODO: check the volumeName from the Trait to match the disk volume name | ||
| if v.Disk.Ephemeral{ |
There was a problem hiding this comment.
how to link to the issue other than paste the link here?
There was a problem hiding this comment.
Just paste it here is good enough.
Also the code looks not "gofmt-ed"?
There was a problem hiding this comment.
thanks, go fmted.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another way to not block volume-mounter on ephemeral volume
~/workspace/oam/rudr (fix-issue-522) $ kc apply -f examples/volumes-ephemeral.yaml
componentschematic.core.oam.dev/server-with-ephemeral-volume created
Error from server: error when creating "examples/volumes-ephemeral.yaml": admission webhook "validate.appconfig.core.oam.dev" denied the request: Container
serverhas a volumnmyvolwith ephemeral volumne so it can't have traintvolume-mounterof type volume-mounter