Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/v4 entities #203

Merged
merged 32 commits into from
Apr 12, 2022
Merged

Feature/v4 entities #203

merged 32 commits into from
Apr 12, 2022

Conversation

200sc
Copy link
Contributor

@200sc 200sc commented Apr 9, 2022

This should follow #201

200sc added 26 commits April 5, 2022 13:12
The former API optimized for a consumer that cared about having the smallest thing possible that met their use case.

This new API optimizes for ease of use-- offering a single thing instead of 6 slightly different things-- removing choice paralysis.

Optimizers would probably prefer writing their own structs anyway.
This enables calling, e.g., ctx.Draw instead of ctx.DrawStack.Draw
This strips out a lot of functionality with the thought being this functionality would need to be rewritten anyway.
@200sc 200sc changed the base branch from master to release/v4.0.0 April 9, 2022 16:01
@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2022

Codecov Report

Merging #203 (21c4487) into release/v4.0.0 (625f93f) will decrease coverage by 1.69%.
The diff coverage is 0.00%.

@@                Coverage Diff                 @@
##           release/v4.0.0     #203      +/-   ##
==================================================
- Coverage           92.51%   90.82%   -1.70%     
==================================================
  Files                 137      138       +1     
  Lines                6149     6255     +106     
==================================================
- Hits                 5689     5681       -8     
- Misses                402      515     +113     
- Partials               58       59       +1     
Impacted Files Coverage Δ
render/mod/highlight.go 0.00% <0.00%> (ø)
loading.go 91.66% <0.00%> (-8.34%) ⬇️
sceneLoop.go 93.10% <0.00%> (-3.45%) ⬇️
drawLoop.go 44.57% <0.00%> (-2.41%) ⬇️
collision/rtree.go 97.90% <0.00%> (-1.40%) ⬇️
shape/condense.go 100.00% <0.00%> (+4.68%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@200sc 200sc marked this pull request as ready for review April 12, 2022 00:34
@200sc 200sc merged commit 8168fee into release/v4.0.0 Apr 12, 2022
@200sc 200sc deleted the feature/v4-entities branch April 12, 2022 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants