-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/v4 entities #203
Merged
Merged
Feature/v4 entities #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t with the new interface
The former API optimized for a consumer that cared about having the smallest thing possible that met their use case. This new API optimizes for ease of use-- offering a single thing instead of 6 slightly different things-- removing choice paralysis. Optimizers would probably prefer writing their own structs anyway.
This enables calling, e.g., ctx.Draw instead of ctx.DrawStack.Draw
This strips out a lot of functionality with the thought being this functionality would need to be rewritten anyway.
Codecov Report
@@ Coverage Diff @@
## release/v4.0.0 #203 +/- ##
==================================================
- Coverage 92.51% 90.82% -1.70%
==================================================
Files 137 138 +1
Lines 6149 6255 +106
==================================================
- Hits 5689 5681 -8
- Misses 402 515 +113
- Partials 58 59 +1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should follow #201