Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lvmdevices: create devices directory #346

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

aesteve-rh
Copy link
Member

Current implementation assumes /etc/lvm/devices folder exists, which may not be true with a fresh installation (only in an upgrade).

We need to make sure that we create the directory
before creating the empty devices file, with
exist_ok flag set to True. This will ensure
that it works in both scenarios.

Fixes: b8692e9
Signed-off-by: Albert Esteve aesteve@redhat.com

Current implementation assumes /etc/lvm/devices folder
exists, which may not be true with a fresh installation
(only in an upgrade).

We need to make sure that we create the directory
before creating the empty devices file, with
exist_ok flag set to True. This will ensure
that it works in both scenarios.

Fixes: b8692e9
Signed-off-by: Albert Esteve <aesteve@redhat.com>
@aesteve-rh aesteve-rh requested a review from nirs as a code owner October 25, 2022 13:12
@aesteve-rh
Copy link
Member Author

@didib fyi

@aesteve-rh aesteve-rh self-assigned this Oct 25, 2022
@aesteve-rh aesteve-rh added bug Issue is a bug or fix for a bug storage labels Oct 25, 2022
@aesteve-rh
Copy link
Member Author

/ost

1 similar comment
@aesteve-rh
Copy link
Member Author

/ost

@aesteve-rh
Copy link
Member Author

/ost

@mz-pdm mz-pdm merged commit 691fb31 into oVirt:master Oct 31, 2022
@aesteve-rh aesteve-rh deleted the aesteve/tool-create-devices-folder branch November 28, 2022 09:21
This was referenced Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is a bug or fix for a bug storage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants