sha1 #394
Open
sha1 #394
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
michalskrivanek
commented
May 25, 2022
michalskrivanek
commented
- certificates: fix confirmation question
- [WIP] remove SHA-1 from cryptotool
michalskrivanek
requested review from
didib,
sandrobonazzola,
ahadas,
bennyz,
emesika,
mwperina,
oliel and
sgratch
as code owners
|
+1 for the packaging part. I do not know well enough the cryptotool to say much. Patch makes sense. Do we need in it any kind of backwards compatibility? How does this work on upgrades? etc. |
|
yeah, backward compatibility is a problem. It probably needs recreation of all engine-side credentials (e.g. for ovn provider and such) |
sandrobonazzola
force-pushed
the
sha1
branch
from
cc8ef4b
to
5026d31
Compare
sandrobonazzola
requested review from
smelamud and
ljelinkova
as code owners
Needs a similar change in aaa-jdbc
sandrobonazzola
removed request for
sandrobonazzola,
smelamud,
ljelinkova,
bennyz,
didib,
ahadas,
emesika,
mwperina and
sgratch
sandrobonazzola
requested review from
dupondje and
sandrobonazzola
and removed request for
oliel and
sandrobonazzola
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.