Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster_upgrade: Fix the engine_correlation_id location #637

Merged

Conversation

mnecas
Copy link
Member

@mnecas mnecas commented Nov 28, 2022

Issue:
When there is random filter in the ansible defaults, and the value is not specified, it does not generate one random number per run but per each use of the unset variable.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2142601

@mnecas mnecas force-pushed the fix-cluster_updated-engine_correlation_id branch from 75bbea0 to 776954b Compare November 28, 2022 08:58
Signed-off-by: Martin Nečas <necas.marty@gmail.com>
@mnecas mnecas force-pushed the fix-cluster_updated-engine_correlation_id branch from 776954b to 1be47be Compare November 28, 2022 08:59
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mnecas mnecas merged commit 215cdf5 into oVirt:master Nov 28, 2022
mnecas added a commit to mnecas/ovirt-ansible-collection that referenced this pull request Nov 28, 2022
Signed-off-by: Martin Nečas <necas.marty@gmail.com>

Signed-off-by: Martin Nečas <necas.marty@gmail.com>
mwperina pushed a commit to mnecas/ovirt-ansible-collection that referenced this pull request Nov 28, 2022
Signed-off-by: Martin Nečas <necas.marty@gmail.com>

Signed-off-by: Martin Nečas <necas.marty@gmail.com>
mwperina pushed a commit that referenced this pull request Nov 28, 2022
…) (#638)

* cluster_upgrade: Fix the engine_correlation_id location (#637)

Signed-off-by: Martin Nečas <necas.marty@gmail.com>

Signed-off-by: Martin Nečas <necas.marty@gmail.com>

* Add python38 to el8stream build

Signed-off-by: Martin Nečas <necas.marty@gmail.com>

Signed-off-by: Martin Nečas <necas.marty@gmail.com>
@mnecas mnecas mentioned this pull request Nov 28, 2022
mnecas added a commit to mnecas/ovirt-ansible-collection that referenced this pull request Dec 12, 2022
Signed-off-by: Martin Nečas <necas.marty@gmail.com>

Signed-off-by: Martin Nečas <necas.marty@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants