-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GLSL language support #490 #824
Conversation
Logo is a mash-up of OpenGL and OpenGL ES logos. All tests pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The primary colors from those two logos look pretty good combined IMO
@o2sh Any feedback before we merge this? |
Yes, sorry about the delay 😓 I'll try to find some time this week to review this PR. The ASCII art could be cleaned/improved, IMO. I'll come back with a suggestion as soon as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution @sangsatori and sorry for the late review.
I left a suggestion.
As a side-note, I wonder if we can update |
Slight changes based on cleaned-up logo by @o2sh o2sh#824 (comment)
I'm afraid that if we enforce guidelines for ASCII art creation, it could go against contributors' creativity and result in uniform-looking designs 🤔 . IMO, we should encourage contributors to express their creativity and come up with unique designs that complement the original logo. Even it means making minor adjustments if necessary 😅 |
Logo is a mash-up of OpenGL and OpenGL ES logos.
All tests pass.