Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: allow user to pick ASCII art with flag --ascii_language #75

Merged
merged 2 commits into from
Oct 13, 2019

Conversation

ktsuench
Copy link
Contributor

@ktsuench ktsuench commented Oct 13, 2019

I implemented the feature using the package Strum to work with the Language enum. Makes it easier to go from string to Language enum. Also, I decided to convert the value from CLI to lowercase and turn all the Language enum values to lowercase for easier comparison plus ease of use.

Use:
Overrides showing the dominant language ascii logo
-a, --ascii_language <ascii_language> [default: ]

Examples:

  1. Flag used with no value provided, defaults to dominant language ASCII logo

image

  1. Flag used with unrecognized language, defaults to dominant language ASCII logo

image

  1. Flag used with recognized language, overrides dominant language ASCII logo

image

  1. Flag used with mixed case recognized language, override dominant language ASCII logo

image

Addresses issue #74

@o2sh
Copy link
Owner

o2sh commented Oct 13, 2019

Great work @ktsuench
And the way you treated the corner cases is just splendid!

Thanks again

@o2sh o2sh merged commit 79164fd into o2sh:master Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants