Add CLI option to disable image #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
o2sh
reviewed
Oct 22, 2020
src/onefetch/cli.rs
Outdated
| @@ -23,6 +23,7 @@ pub struct Cli { | |||
| pub excluded: Vec<String>, | |||
| pub print_languages: bool, | |||
| pub true_color: bool, | |||
| pub image_off: bool, | |||
There was a problem hiding this comment.
As it's not only for images, maybe it would be better to name it art_off
src/onefetch/info.rs
Outdated
Comment on lines
260
to
262
| while let Some(line) = info_lines.next() { | ||
| writeln!(f, "{}", line)?; | ||
| } |
There was a problem hiding this comment.
I don't think you need to iterate over info_lines, writeln!(f, "{}\n", buf)? should be enough
o2sh
reviewed
Oct 22, 2020
| ) | ||
| .arg( | ||
| Arg::with_name("off") | ||
| .long("off") |
There was a problem hiding this comment.
Maybe we should add .conflicts_with_all(&["image", "ascii-language", "ascii-input"])
Renames `image_off` to `art_off` since it will not only turn of images, removes unnecessary iteration while printing, and defines conflicting CLI arguments for `--off`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #287
Adds the CLI option
--offwhich prevents the image from being displayed.