Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for CMake, Emacs Lisp, Fish and Nix #158

Merged
merged 9 commits into from
Nov 11, 2019
Merged

Added support for CMake, Emacs Lisp, Fish and Nix #158

merged 9 commits into from
Nov 11, 2019

Conversation

Phundrak
Copy link
Contributor

These changes are basically the same as my previous PR (#155), but this time I added language support for CMake, Emacs Lisp, Fish and Nix.

I also fixed the display for Org, which was displayed as “Org-mode” instead. Each of these additions were tested against git repos mainly relying on one of these languages.
The only issue I have is with the Nix logo, it seems my terminal emulator (Luke Smith’s build of st) won’t display any differently Color::Blue and Color::BrightBlue, but my guess is this is an issue with colored.

…p.ascii

Changed the display of Elisp from "Emacs Lisp" to "EmacsLisp", apparently
onefetch doesn’t handle spaces in language names well. Also adding the
serialization with strum helped avoiding thread panic.
For consistency with the displayed name, `elisp.ascii` was renamed
`emacslisp.ascii`.
@o2sh o2sh self-requested a review November 10, 2019 18:09
Copy link
Owner

@o2sh o2sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably get rid of #[strum(serialize = "org-mode")], other than that everything looks good to me.

You may be the first contributor to add multiple languages at once 🥇

Looking forward to merge your PR

@Phundrak
Copy link
Contributor Author

Oh, right, I completely forgot I added this line, it is now removed.
Oh, really? Happy to help! 👍

@o2sh o2sh merged commit 7ed1c6a into o2sh:master Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants