Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed several clippy warnings #140

Merged
merged 14 commits into from
Oct 31, 2019
Merged

Fixed several clippy warnings #140

merged 14 commits into from
Oct 31, 2019

Conversation

ZapAnton
Copy link
Contributor

@ZapAnton ZapAnton commented Oct 31, 2019 •
edited
Loading

This PR fixes some clippy warnings, in order to reduce the clippy output noise, so only relevant lints would be visible.

ZapAnton added 14 commits October 31, 2019 16:50
@ZapAnton
Fixed the 'redundant field names in struct initialization' clippy
cb97ca1 
warning.

Relevant lint: https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
@ZapAnton
Fixed the 'char_lit_as_u8' clippy warning
54d9951 
Relevant lint: https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
@ZapAnton
Fixed the 'cast_lossless' clippy warning
3582a88 
Relevant lint: https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
@ZapAnton
Fixed the 'op_ref' clippy warning
cf815c0 
Relevant lint: https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
@ZapAnton
Fixed the 'write_literal' clippy warning
d868275 
Relevant lint: https://rust-lang.github.io/rust-clippy/master/index.html#write_literal
@ZapAnton
Fixed the 'ptr_arg' clippy warning
065d65a 
Relevant lint: https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
@ZapAnton
Fixed the 'single_char_pattern' clippy warning
ddb100c 
Relevant lint: https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
@ZapAnton
Fixed the needless_lifetimes clippy warning
95b5b75 
Relevant lint: https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
@ZapAnton
Fixed the 'identity_conversion' clippy warning
090493e 
Relevant lint: https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
@ZapAnton
Fixed the 'len_zero' clippy warning
b214dc2 
Relevant lint: https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
@ZapAnton
Fixed the redundant_pattern_matching clippy warning
8e85b53 
Relevant lint: https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
@ZapAnton
Fixed the 'clone_on_copy' clippy warning
cc59305 
Relevant lint: https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
@ZapAnton
Fixed the 'needless_collect' clippy warning
0ea794b 
Relevant lint: https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect
@ZapAnton
Applied 'cargo fmt'
615eecd
@o2sh o2sh requested review from andymac-2 and removed request for andymac-2 October 31, 2019 14:51
@o2sh
Copy link
Owner

o2sh commented Oct 31, 2019

Thanks a lot @ZapAnton 👍

@o2sh o2sh merged commit 1e10bd2 into o2sh:master Oct 31, 2019
@ZapAnton ZapAnton deleted the fix_clippy_warnings branch October 31, 2019 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZapAnton @o2sh