Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add release.yml file #1177

Merged
merged 2 commits into from
Sep 22, 2023
Merged

add release.yml file #1177

merged 2 commits into from
Sep 22, 2023

Conversation

o2sh
Copy link
Owner

@o2sh o2sh commented Sep 21, 2023

as suggested in #1175

@o2sh o2sh added the chore label Sep 21, 2023
@o2sh o2sh requested a review from spenserblack as a code owner September 21, 2023 22:31
spenserblack
spenserblack approved these changes Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

You might want to consider setting up a label exclude-from-release or something, to explicitly hide some PRs from the generated changelog. For example, in gengo, I'm planning on using it to ignore refactoring PRs, since that's not user-facing.

@o2sh o2sh merged commit 70077bd into main Sep 22, 2023
@o2sh o2sh deleted the chore/add-release-file branch March 17, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spenserblack spenserblack spenserblack approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@o2sh @spenserblack