Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo information picks strange remote #314

Closed
clux opened this issue Nov 9, 2020 · 2 comments
Closed

Repo information picks strange remote #314

clux opened this issue Nov 9, 2020 · 2 comments

Comments

@clux
Copy link

clux commented Nov 9, 2020

If git remote -v has more than one remote, the one picked seems strange to me (i got a random one from an old pr).

The repo url should probably be taken from the origin remote if it exists.

@o2sh
Copy link
Owner

o2sh commented Nov 9, 2020

Hi @clux
With a183a32, we now look for remote.origin.url as the default choice and if it doesn't exist we fallback to the first entry matching Regex::new(r"remote\.[a-zA-Z0-9]+\.url")

@clux
Copy link
Author

clux commented Nov 9, 2020

Ah, that was quick. Thank you. That looks good to me!

@o2sh o2sh closed this as completed Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants