Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move detection of existing images in base image to own web service #105

Closed
nuest opened this issue Aug 15, 2018 · 1 comment
Closed

Move detection of existing images in base image to own web service #105

nuest opened this issue Aug 15, 2018 · 1 comment

Comments

@nuest
Copy link
Member

nuest commented Aug 15, 2018

Right now as implemented in

the filtering of base images relies on the containerit container to have access to a Docker socket (works) but also the container must be run as a user with access to Docker - which the rstudio user is not. One could add rstudio to the local Docker user group on developer machines, but that's not good.

So the package detection only works when muncher is running containerised.

A better solution in the long run would be to move the detection of installed packages to it's own API endpoint, whose implementing service could be written in R (or just be added to o2r-inspecter).

A web service would also be beneficial for caching!

nuest added a commit to nuest/o2r-muncher that referenced this issue Aug 15, 2018
also update project website urls,
preliminary implementation related to o2r-project#105
@nuest nuest closed this as completed Mar 18, 2020
@nuest
Copy link
Member Author

nuest commented Mar 18, 2020

Would make things too complicated, let's leave this within containerit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant