-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compute p@10 using 0 == irrel, 1+ == rel, so that P@10 is in the expected range [0..1] #991
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
3f63549
Compute p@10 using 0 == irrel, 1+ == rel, so that P@10 is in the expe…
55e368f
Compute count, not rank divided by total.
914b40e
Merge branch 'main' into fix-p@10
epugh 3df1a9c
Trigger a migration for existing Quepid users to get the new P@10 jav…
epugh 8fef7a8
Merge branch 'main' into fix-p@10
0800e1f
Do that math in a mathy way
9e48483
lint!
epugh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
class ReindexPAt10Code < ActiveRecord::Migration[7.1] | ||
# force existing P@10 scorers to reload using the latest scorer information. | ||
def change | ||
scorers_to_update = ['P@10'] | ||
scorers_to_update.each do |scorer_name| | ||
scorer = Scorer.where(name: scorer_name, communal: true).first | ||
name = scorer.name | ||
scorer.code = File.readlines("./db/scorers/#{name.downcase}.js",'\n').join('\n') | ||
scorer.save! | ||
end | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,4 +1,11 @@ | ||||||
var k = 10 // @Rank | ||||||
var score = avgRating(k); | ||||||
|
||||||
const k = 10; // @Rank | ||||||
// k may be > length list, so count up the total number of documents processed. | ||||||
let count = 0, total = 0; | ||||||
eachDoc(function(doc, i) { | ||||||
if (hasDocRating(i) && (docRating(i)) > 0) { // map 0 -> irrel, 1+ ->rel | ||||||
count = count i+1 | ||||||
} | ||||||
total = total + 1 | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
}, k); | ||||||
const score = count / total : 0.0; | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This line gives me an error... |
||||||
setScore(score); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.