Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce logging when creating snapshots #942

Merged
merged 2 commits into from
Feb 4, 2024
Merged

Reduce logging when creating snapshots #942

merged 2 commits into from
Feb 4, 2024

Conversation

reid-rigo
Copy link
Contributor

Description

Snapshot creation is slow and clunky to test because the amount of logging it generates. This does two things:

  • Filters snapshot.docs to not output the giant POST body
  • Sets up TruncatingFormatter in dev mode to shorten SQL logging

epugh
epugh approved these changes Feb 4, 2024
View reviewed changes
Copy link
Member

@epugh epugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful

config/initializers/filter_parameter_logging.rb
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitly cleaner!

lib/truncating_formatter.rb
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried for a while to make something work and was constantly foiled, this looks so elegantly simple!

@epugh epugh merged commit bf99022 into o19s:main Feb 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epugh epugh epugh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reid-rigo @epugh