Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing admins to create "app announcements" which are then shown to users until they are marked as viewed #911

Merged
merged 14 commits into from
Feb 1, 2024

Conversation

mkr
Copy link
Contributor

@mkr mkr commented Dec 21, 2023

First draft steps at implementing #848

@mkr mkr force-pushed the feature/848_app_announcement branch from c3ab6d6 to 0a7836f Compare December 22, 2023 10:27
@epugh
Copy link
Member

epugh commented Dec 22, 2023

I am investigating the "right" way to do Ajax call back to dismiss the message....

@mkr mkr force-pushed the feature/848_app_announcement branch from 0a7836f to a7e3415 Compare December 22, 2023 14:07
@epugh
Copy link
Member

epugh commented Jan 31, 2024

i told @flaxsearch we would get this over the finish line this week. I'm going to try for somethign simpler which is to show the alert message in line with the page load, and in that process flag it as "viewed" so we don't ahve to worry about the ajax call back......

@epugh epugh marked this pull request as ready for review January 31, 2024 23:05
@epugh
Copy link
Member

epugh commented Jan 31, 2024

@mkr could you take a spin through this? And we'll get @flaxsearch blessing tomorrow and then can ship it.

@epugh epugh merged commit cb75da1 into main Feb 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants