Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the logic for the default ES and Solr server definitions from server AND client side to just client side #505

Merged
merged 9 commits into from
May 8, 2022

Conversation

epugh
Copy link
Member

@epugh epugh commented May 7, 2022

Description

There is an odd experience if you start out in https mode quepid, and then get a http default solr. Plus the defaults are defined both on the server side and client side, and they are different!

Lastly, we have some bugs in the default definitions ;-)

Motivation and Context

refactoring the code for simpliicty, and better onboarding experience.

How Has This Been Tested?

Screenshots or GIFs (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • [] New feature (non-breaking change which adds new functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [] My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [] I have read the CONTRIBUTING document.
  • [] I have added tests to cover my changes.
  • [] All new and existing tests passed.

@epugh epugh linked an issue May 7, 2022 that may be closed by this pull request
@epugh epugh merged commit e8eb411 into master May 8, 2022
@epugh epugh deleted the swap_to_https_demo_servers branch July 5, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change default solr and es to https versions since app.quepid.com is https
1 participant