Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make JSONP versus GET an option for Solr, default to JSONP #495

Merged
merged 8 commits into from
Apr 23, 2022

Conversation

epugh
Copy link
Member

@epugh epugh commented Apr 19, 2022

Description

New functionality to allow you to specific GET instead of JSONP for the apiMethod to Solr. If you have a API that is mimicking Solr, well, you don't need the JSONP if you hvae proper cors support. THis can simplify some folks lives

Motivation and Context

Baby step towards supporting the Solr V2 API (which is JSON POST), and introduces into the wizard a option to have settings for a serach engine.

In the future maybe we share a search engine with a Team, so thers can pick from a list...

How Has This Been Tested?

Screenshots or GIFs (if appropriate):

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds new functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [] My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [] I have read the CONTRIBUTING document.
  • [] I have added tests to cover my changes.
  • [] All new and existing tests passed.

epugh@opensourceconnections.com added 3 commits April 16, 2022 14:46
@epugh epugh requested a review from worleydl April 19, 2022 15:49
@epugh epugh merged commit df51718 into master Apr 23, 2022
@epugh epugh deleted the make_jsonp_optional branch July 5, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant