Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump version of splainer to deal with performance issues in looking up a single solr doc #456

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

epugh
Copy link
Member

@epugh epugh commented Dec 17, 2021

Description

This fixes #442 by turning off the default parameter to facet on EVERY single field that you might be listing in Quepid when you look up a single doc.

Motivation and Context

No idea why the facet thing was there... From the dawn of Quepid... <-- @softwaredoug do you have any ideas?

How Has This Been Tested?

Manually

Screenshots or GIFs (if appropriate):

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] Improvement (non-breaking change which improves existing functionality)
  • [] New feature (non-breaking change which adds new functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [] My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [] I have read the CONTRIBUTING document.
  • [] I have added tests to cover my changes.
  • [] All new and existing tests passed.

@epugh epugh temporarily deployed to quepid-pr-456 December 17, 2021 19:27 Inactive
@epugh epugh merged commit 96e1546 into master Dec 17, 2021
@epugh epugh deleted the bump_splainer_to_make_single_doc_lookups_faster branch January 8, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Faceting slowing performance
1 participant