Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for if Google Analytics Setup invokes a lib file directly which causes class loader issues in Dev. #419

Merged
merged 4 commits into from
Sep 27, 2021

Conversation

epugh
Copy link
Member

@epugh epugh commented Sep 27, 2021

Description

Change how we check if GA is running

Motivation and Context

During Dev mode, we get lots of werid class loader issues.

How Has This Been Tested?

manually

Screenshots or GIFs (if appropriate):

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • [] New feature (non-breaking change which adds new functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [] My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [] I have read the CONTRIBUTING document.
  • [] I have added tests to cover my changes.
  • [] All new and existing tests passed.

@epugh epugh temporarily deployed to quepid-pr-419 September 27, 2021 17:11 Inactive
@epugh epugh temporarily deployed to quepid-pr-419 September 27, 2021 18:55 Inactive
@epugh epugh temporarily deployed to quepid-pr-419 September 27, 2021 18:59 Inactive
@epugh epugh temporarily deployed to quepid-pr-419 September 27, 2021 19:16 Inactive
@epugh epugh changed the title lets not invoke a lib file directly Check for if Google Analytics Setup invokes a lib file directly which causes class loader issues in Dev. Sep 27, 2021
@epugh epugh merged commit e32000f into master Sep 27, 2021
@epugh epugh linked an issue Sep 28, 2021 that may be closed by this pull request
@epugh epugh deleted the reduce_magic_lib_loading_errors branch January 8, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace this check with a constant!
1 participant