Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning on solr syntax issues #394

Merged
merged 2 commits into from
Aug 6, 2021
Merged

Conversation

epugh
Copy link
Member

@epugh epugh commented Aug 6, 2021

Description

we had an old feature that would warn on mis typed params.

Motivation and Context

I found it, the feature is cool, but the impl was broken, so now it works.

How Has This Been Tested?

manually

Screenshots or GIFs (if appropriate):

Screenshot at Aug 06 17-11-11

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] Improvement (non-breaking change which improves existing functionality)
  • [] New feature (non-breaking change which adds new functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

<!x--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->

  • [] My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [] I have read the CONTRIBUTING document.
  • [] I have added tests to cover my changes.
  • All new and existing tests passed.

@epugh epugh requested a deployment to quepid-pr-394 August 6, 2021 21:21 Abandoned
@epugh epugh temporarily deployed to quepid-pr-394 August 6, 2021 21:26 Inactive
@epugh epugh merged commit 3d4afa7 into master Aug 6, 2021
@epugh epugh deleted the restore_solr_syntax_validation_feature branch January 8, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant