Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a result evaluation leasds to UI slowness and huge number of requests to the backend #330

Closed
thePanz opened this issue Apr 28, 2021 · 12 comments · Fixed by #491 or #490
Closed

Comments

@thePanz
Copy link

thePanz commented Apr 28, 2021

Describe the bug
Adding 1 evaluation triggers 300+ requests, and a huge delay in the UI

To Reproduce
Steps to reproduce the behavior:

  1. Create a new relevance case with ES as search backend
  2. Add 10 keywords (which leads to results)
  3. Add evaluation grades to each result
  4. Try to add another grade: it is not possible as the UI is frozen for few seconds
  5. Check the Network tab of the browser: for each added grade, multiple requests (up to 300 in my case) are triggered to the backend and ES

Expected behavior

  • Adding evaluations should trigger the minimum amount of requests to the backend
  • some requests are the same (around 48 requests for 1 added grade) to /api/cases/1/scores/all
  • if possible allow to manually refresh the "case's scores", and do not automatically trigger it after adding a single grade

Screenshots
The requests (327) are related to adding 1 grade (I cleaned the "network" tab before clicking on the grade)
image

Additional context

  • ES is my backend
  • The search case has 25 searches/keywords
  • Each search has from 10 to 250 results each
@epugh
Copy link
Member

epugh commented Apr 28, 2021

Thank you for this issue! I had felt like I was seeing really large number of queries in logs on the server side, and just a general sense of slowness. I'd love some help tracking down when this issue might have been introduced....

@thePanz
Copy link
Author

thePanz commented Apr 29, 2021

I had the same behavior with the latest 2 releases (I am using the official docker images)
Let me know how I can support you :)

@epugh
Copy link
Member

epugh commented Apr 29, 2021

can you confirm you saw the issue in 6.4.1 docker image? Would you be willing to retest in 6.3.2? I was assuming this was caused due to Rails 5 upgrade that happened in 6.5.0, but maybe it's been there for longer... If it isn't in 6.3.2, then it was probably introduced by the work for the "Show Only Rated" toggle feature.....

@thePanz
Copy link
Author

thePanz commented May 20, 2021

@epugh I can confirm that using the docker-image v6.3.2 (with the same DB), the UI does NOT have the slowdown issue.
The problem might have been introduced after v6.3.2

@thePanz
Copy link
Author

thePanz commented Jun 17, 2021

@epugh any update on this issue? :)

@epugh
Copy link
Member

epugh commented Jun 17, 2021

Not really ;-(. Would you be willing to schedule a short Zoom call to look at this issue together and make sure I can duplicate it? https://calendly.com/epugh/30-minute-quepid-qonversation

@epugh
Copy link
Member

epugh commented Aug 4, 2021

Did you want to look at this again? I'm prepping for the next release, so if there is an issue, now is a good bug swatting time to find this!

@epugh
Copy link
Member

epugh commented Sep 19, 2021

image

I am seeing this ;-( One query, and a BUNCH of calls...

@stale
Copy link

stale bot commented Dec 21, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please do advocate for this issue and ideally submit a patch to get the attention of the maintainers!

@stale stale bot added the wontfix This will not be worked on label Dec 21, 2021
@thePanz
Copy link
Author

thePanz commented Dec 21, 2021

@epugh unfortunately I am not using this tool anymore, but ""happy"" to hear that you've been able to reproduce the issue :)

@stale stale bot removed the wontfix This will not be worked on label Dec 21, 2021
@epugh
Copy link
Member

epugh commented Dec 29, 2021

Ugh, found it again!

@epugh
Copy link
Member

epugh commented Apr 7, 2022

@worleydl ping!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants