remove Best option since we don't grok it. (#948)

o19s · Feb 7, 2024 · f17f367 · f17f367
1 parent fb4d3ab
commit f17f367
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 103 deletions.
diff --git a/app/assets/javascripts/components/diff/_modal.html b/app/assets/javascripts/components/diff/_modal.html
@@ -40,10 +40,7 @@ <h3 class="modal-title">Compare Your Search Results</h3>
       </div>
     </div>
 
-    <div class="form-group">
-      <input type="radio" id="best" name="diffSelection" value="best" ng-model="ctrl.which">
-      <label for="best">Highest Rated</label>
-    </div>
+
 
     <div class="form-group">
       <input type="radio" id="disable" name="diffSelection" value="none" ng-model="ctrl.which">
@@ -69,6 +66,6 @@ <h3 class="modal-title">Compare Your Search Results</h3>
   </button>
 
   <div ng-show="ctrl.inProgress">
-    Fetching snapshot info, this may take a moment or two depending on the number of queries to fetch...
+    Fetching snapshot info, this may take a moment or two depending on the number of queries to run...
   </div>
 </div>
diff --git a/app/assets/javascripts/components/diff/diff_modal_instance_controller.js b/app/assets/javascripts/components/diff/diff_modal_instance_controller.js
@@ -46,9 +46,7 @@ angular.module('QuepidApp')
       });
 
       // Init
-      if (initialSelection === 'best') {
-        ctrl.which = 'best';
-      } else if (initialSelection === null) {
+      if (initialSelection === null) {
         ctrl.which = 'none';
       }
 
@@ -113,9 +111,7 @@ angular.module('QuepidApp')
       }
 
       function ok() {
-        if (ctrl.which === 'best') {
-          $uibModalInstance.close('best');
-        } else if (ctrl.which === 'none') {
+        if (ctrl.which === 'none') {
           $uibModalInstance.close(null);
         } else {
           ctrl.inProgress = true;
@@ -133,7 +129,6 @@ angular.module('QuepidApp')
       }
 
       function cancel() {
-        //$uibModalInstance.dismiss();
         $uibModalInstance.dismiss('cancel');
       }
     }

diff --git a/app/assets/javascripts/services/bestFetcherSvc.js b/app/assets/javascripts/services/bestFetcherSvc.js
diff --git a/app/assets/javascripts/services/diffResultsSvc.js b/app/assets/javascripts/services/diffResultsSvc.js
@@ -10,13 +10,11 @@ angular.module('QuepidApp')
     '$log',
     'querySnapshotSvc',
     'settingsSvc',
-    'bestFetcherSvc',
     function diffResultsSvc(
       $q,
       $log,
       querySnapshotSvc,
-      settingsSvc,
-      bestFetcherSvc
+      settingsSvc
     ) {
 
       var diffSetting = null;
@@ -129,10 +127,7 @@ angular.module('QuepidApp')
         var fetcher = nullFetcher;
 
         if (diffSetting === null) {
-          query.diff = null;
-        } else if (diffSetting === 'best') {
-          fetcher = bestFetcherSvc.createBestFetcher(query.ratingsStore);
-          query.diff = new QueryDiffResults(query, fetcher, 'best');
+          query.diff = null;          
         } else {
           var snapshot = querySnapshotSvc.snapshots[diffSetting];
 

diff --git a/app/assets/javascripts/services/queryViewSvc.js b/app/assets/javascripts/services/queryViewSvc.js
@@ -5,8 +5,8 @@
 angular.module('QuepidApp')
   .service('queryViewSvc', [
     function() {
-      this.enableDiff = function(idOrBest) {
-        this.diffSetting = idOrBest;
+      this.enableDiff = function(snapshotId) {
+        this.diffSetting = snapshotId;
       };
 
       this.isDiffEnabled = function() {

diff --git a/spec/javascripts/angular/services/diffResultsSvc_spec.js b/spec/javascripts/angular/services/diffResultsSvc_spec.js
@@ -173,20 +173,4 @@ describe('Service: diffResultsSvc', function() {
     });
   });
 
-  it('fetches best docs', function() {
-    diffResultsSvc.setDiffSetting('best');
-    diffResultsSvc.createQueryDiff(fakeQuery);
-    expect(fakeQuery.diff.docs().length).toEqual(0);
-
-    fakeQuery.diff.fetch().then(function() {
-      expect(fakeQuery.diff.docs().length).toEqual(3);
-      var diffDocs = fakeQuery.diff.docs();
-      expect(diffDocs[0].id).toEqual(doc3.id);
-      expect(diffDocs[1].id).toEqual(doc2.id);
-      expect(diffDocs[2].id).toEqual(doc1.id);
-    });
-
-    $rootScope.$apply();
-  });
-
 });