o1vm/riscv32im: implement jal #2915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannywillems
changed the title
dannywillems
force-pushed
the
dw/o1vm/riscv32im-jalr
branch
from
0ea9178 to
4d28ae8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2915 +/- ##
==========================================
+ Coverage 73.37% 73.45% +0.07%
==========================================
Files 259 259
Lines 61553 61593 +40
==========================================
+ Hits 45166 45244 +78
+ Misses 16387 16349 -38 ☔ View full report in Codecov by Sentry. |
dannywillems
force-pushed
the
dw/o1vm/riscv32im-jalr
branch
2 times, most recently
from
19f880d to
b24cccb
Compare
dannywillems
force-pushed
the
dw/o1vm/riscv32im-jalr
branch
from
b24cccb to
43c4dfa
Compare
dannywillems
commented
Dec 28, 2024
| let res_scratch = env.alloc_scratch(); | ||
| let overflow_scratch = env.alloc_scratch(); | ||
| let (res, _overflow) = unsafe { | ||
| env.add_witness(&instruction_pointer, &offset, res_scratch, overflow_scratch) |
There was a problem hiding this comment.
It is not next_instruction_pointer. Spent minutes on this!
svv232
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.