-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gen-state-json #2911
Merged
Merged
gen-state-json #2911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martyall
force-pushed
the
martin/gen-state-json
branch
2 times, most recently
from
December 24, 2024 20:16
3616915
to
18c3784
Compare
martyall
force-pushed
the
martin/gen-state-json
branch
from
December 24, 2024 20:26
18c3784
to
5fc0c95
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2911 +/- ##
==========================================
- Coverage 73.45% 73.44% -0.02%
==========================================
Files 259 259
Lines 61593 61618 +25
==========================================
+ Hits 45243 45253 +10
- Misses 16350 16365 +15 ☔ View full report in Codecov by Sentry. |
martyall
force-pushed
the
martin/gen-state-json
branch
9 times, most recently
from
December 26, 2024 23:30
0e62b23
to
9485af0
Compare
martyall
force-pushed
the
martin/gen-state-json
branch
2 times, most recently
from
December 27, 2024 00:08
b0d4ae0
to
fe5ffcb
Compare
dannywillems
reviewed
Jan 2, 2025
dannywillems
reviewed
Jan 2, 2025
dannywillems
reviewed
Jan 2, 2025
dannywillems
reviewed
Jan 2, 2025
dannywillems
reviewed
Jan 2, 2025
dannywillems
reviewed
Jan 2, 2025
dannywillems
reviewed
Jan 2, 2025
dannywillems
force-pushed
the
dw/mips-makefile-import
branch
2 times, most recently
from
January 2, 2025 09:56
4cf77b5
to
2637499
Compare
martyall
force-pushed
the
martin/gen-state-json
branch
from
January 2, 2025 17:03
e2587ed
to
57c7ec1
Compare
dannywillems
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to test #2906 and also the
elf_loader
module. Additionally, we generalize theelf_loader
to work with both riscv and mipsChanges
elf_loader
to work with mips/ simplify some indices during memory-page construction.o1vm/resources/programs/mips/bin
and add to gitignoreo1vm/test-gen-state-json.sh
which tests the elf loader /state.json
generator over all of the example mips programs.MIPS Build and Package
github workflow that runs on dispatch trigger. This workflow:make build-mips-programs
to build all of the example mips program binaries.meta.json
file optional inpickles_o1vm
cli. This simple change is not needed for the above -- it was picked over by mistake. Still, the change is trivial and needed for later work so I'm hoping we can keep it.