Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gen-state-json #2911

Merged
merged 7 commits into from
Jan 2, 2025
Merged

gen-state-json #2911

merged 7 commits into from
Jan 2, 2025

Conversation

martyall
Copy link
Contributor

@martyall martyall commented Dec 24, 2024

This PR is meant to test #2906 and also the elf_loader module. Additionally, we generalize the elf_loader to work with both riscv and mips

Changes

  • generalize elf_loader to work with mips/ simplify some indices during memory-page construction.
  • remove the generated dir o1vm/resources/programs/mips/bin and add to gitignore
  • add a test script o1vm/test-gen-state-json.sh which tests the elf loader / state.json generator over all of the example mips programs.
  • added a MIPS Build and Package github workflow that runs on dispatch trigger. This workflow:
    1. builds the mips tools
    2. runs make build-mips-programs to build all of the example mips program binaries.
    3. checks that our elf loader can parse these programs
    4. uploads a tar file and provides a URL for downloads (intended for devs who don't have the tools to build them locally)
  • makes meta.json file optional in pickles_o1vm cli. This simple change is not needed for the above -- it was picked over by mistake. Still, the change is trivial and needed for later work so I'm hoping we can keep it.

@martyall martyall force-pushed the martin/gen-state-json branch 2 times, most recently from 3616915 to 18c3784 Compare December 24, 2024 20:16
@martyall martyall changed the base branch from master to dw/mips-makefile-import December 24, 2024 20:16
@martyall martyall force-pushed the martin/gen-state-json branch from 18c3784 to 5fc0c95 Compare December 24, 2024 20:26
@martyall martyall marked this pull request as draft December 24, 2024 20:33
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 46 lines in your changes missing coverage. Please review.

Project coverage is 73.44%. Comparing base (2637499) to head (84c1103).
Report is 18 commits behind head on master.

Files with missing lines Patch % Lines
o1vm/src/legacy/main.rs 0.00% 16 Missing ⚠️
o1vm/src/pickles/main.rs 0.00% 16 Missing ⚠️
o1vm/src/elf_loader.rs 79.31% 6 Missing ⚠️
o1vm/src/interpreters/mips/witness.rs 0.00% 5 Missing ⚠️
o1vm/src/cli/cannon.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2911      +/-   ##
==========================================
- Coverage   73.45%   73.44%   -0.02%     
==========================================
  Files         259      259              
  Lines       61593    61618      +25     
==========================================
+ Hits        45243    45253      +10     
- Misses      16350    16365      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martyall martyall force-pushed the martin/gen-state-json branch 9 times, most recently from 0e62b23 to 9485af0 Compare December 26, 2024 23:30
@martyall martyall marked this pull request as ready for review December 26, 2024 23:44
@martyall martyall force-pushed the martin/gen-state-json branch 2 times, most recently from b0d4ae0 to fe5ffcb Compare December 27, 2024 00:08
o1vm/meta_test.json Outdated Show resolved Hide resolved
o1vm/src/elf_loader.rs Outdated Show resolved Hide resolved
@dannywillems dannywillems force-pushed the dw/mips-makefile-import branch 2 times, most recently from 4cf77b5 to 2637499 Compare January 2, 2025 09:56
@martyall martyall force-pushed the martin/gen-state-json branch from e2587ed to 57c7ec1 Compare January 2, 2025 17:03
@martyall martyall requested a review from dannywillems January 2, 2025 17:20
Base automatically changed from dw/mips-makefile-import to master January 2, 2025 17:34
@martyall martyall merged commit c6dc6de into master Jan 2, 2025
7 of 8 checks passed
@martyall martyall deleted the martin/gen-state-json branch January 2, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants