o1vm/riscv32: implement M type instruction divu #2807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svv232
reviewed
Nov 20, 2024
| @@ -2193,7 +2193,17 @@ pub fn interpret_mtype<Env: InterpreterEnv>(env: &mut Env, instr: MInstruction) | |||
| env.set_next_instruction_pointer(next_instruction_pointer + Env::constant(4u32)); | |||
| } | |||
| MInstruction::Divu => { | |||
| unimplemented!("Divu") | |||
There was a problem hiding this comment.
it would be nice to comment the implementation from https://msyksphinz-self.github.io/riscv-isadoc/html/rvm.html
There was a problem hiding this comment.
we can follow up with this documentation in a future pr
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2807 +/- ##
==========================================
- Coverage 71.93% 71.92% -0.01%
==========================================
Files 257 257
Lines 60271 60275 +4
==========================================
- Hits 43357 43355 -2
- Misses 16914 16920 +6 ☔ View full report in Codecov by Sentry. |
dannywillems
force-pushed
the
dw/riscv32/remove-divmod
branch
from
d7e039d to
7482d1b
Compare
svv232
approved these changes
Dec 3, 2024
dannywillems
force-pushed
the
dw/riscv32-impl-m-type-divu
branch
from
b44fedc to
e084008
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.