o1vm/riscv32: remove unused divmod_signed #2802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svv232
approved these changes
Nov 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2802 +/- ##
==========================================
+ Coverage 71.92% 71.95% +0.03%
==========================================
Files 256 256
Lines 60241 60212 -29
==========================================
- Hits 43327 43326 -1
+ Misses 16914 16886 -28 ☔ View full report in Codecov by Sentry. |
dannywillems
force-pushed
the
dw/o1vm/riscv32/implement-mod-signed
branch
from
bd3e706 to
4e0220d
Compare
As for mul_hi_lo(_signed), the method is splitted.
dannywillems
force-pushed
the
dw/o1vm/riscv32/remove-unused-divmod-signed
branch
from
de7f623 to
77a50c4
Compare
|
Rebased |
Base automatically changed from
dw/o1vm/riscv32/implement-mod-signed
to
master
December 2, 2024 21:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As for mul_hi_lo(_signed), the method is splitted.