Fix fetchMissingData: re-fetch cached accounts #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #430 (let's see if this can finally stay closed!)
this is confirmed to fix one instance of stale account data (incorrect nonce) used by
Mina.transaction. The issue was that an account that already was fecthed once, and was therefore cached, was not re-fetched when it was marked to be fetched duringMina.transaction. This meant that an account that was updated by an earlier transaction remained stale.The simple solution is to fetch all accounts that are marked for fetching.
closes #599
as a side-effect, this makes the cache invalidation timeout completely unused, therefore we remove it and close the issue of making it configurable