Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Uint comparisons and division #503

Merged
merged 7 commits into from
Oct 26, 2022
Merged

Fix Uint comparisons and division #503

merged 7 commits into from
Oct 26, 2022

Conversation

mitschabaude
Copy link
Contributor

@mitschabaude mitschabaude commented Oct 24, 2022 •
edited
Loading

bkase
bkase requested changes Oct 24, 2022
View reviewed changes
Copy link
Member

@bkase bkase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a unit test we could have had that would catch this? Could you add that?

@Trivo25 Trivo25 mentioned this pull request Oct 26, 2022
Merged
Base automatically changed from dex/vesting to main October 26, 2022 23:19
@mitschabaude mitschabaude merged commit 2787994 into main Oct 26, 2022
@mitschabaude mitschabaude deleted the fix/uint-lt-gt branch October 26, 2022 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkase bkase bkase approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unknown constraint failure; commented out line in Dex [snarkyjs] UInt32.mod() doesn't work inside a proof
2 participants
@mitschabaude @bkase