-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Callbacks via composability #428
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-> to still be able to identify the same update, give them an id
MartinMinkov
approved these changes
Sep 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre approving! Looks great, awesome work 🚀
(so that Mina CI can be independent of checked-in bindings)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provable<AccountUpdate>
)authorize
method, which can (should) be used on AccountUpdates that are passed to methods:In this case,
authorize
simply takes the AccountUpdate and makes it a child of the zkApp ("adopts it").There's also an advanced second parameter to witness a certain layout of child updates:
The weird layout syntax is documented here:
https://github.com/o1-labs/snarkyjs/blob/2bf421ba36780c4dc644552e02a6d2dcfe51036c/src/lib/account_update.ts#L1211-L1230
authorize
can be used to achieve what the callback was all about: instead of taking a "zkApp callback" and extracting the account update in the authorizing method, we let it be up to the method's caller to get the account update, and pass it in directly.The caller could, for example, do this
thirdZkapp.self
authorizingMethod
above, which usesauthorize
(and then does checks on the witnessed account update tree, like summing up the balances)If this is done, the functionality is equivalent to a callback, with the difference that the caller can also see the result of the callback! (which, it turns out, is what we often want)
Let's call this flow "manual callback".
The "manual callback" flow is safer than the old callback, because our zkApps composability machinery ensures that we properly prove in the caller's circuit that
thirdZkapp
was really called, with certain arguments and outputs.This PR also:
.toPretty()
./run
scriptCircuit.witness
works