Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #310
Code cleanup PR which mostly affects
parties-leaves.ts
. Instead of having multiple "modules" likeToFields
,ToJson
etc, each of which has conversion functions for the core party types likeField
,Bool
,PublicKey
, etc, we "transpose" the code structure, so that we have multiple types, each of which implements methods liketoFields
,toJson
etc. This reduces lots of redundant code since we already implement most of these methods on most of these types, elsewhere.As a side effect, this PR has to implement the new
toInput
method (introduced by #310) onCircuitValue
,Field
,Bool
and on the type returned bycircuitValue()