Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cache access structure and update submodules to the latest #1804

Merged
merged 4 commits into from
Aug 23, 2024
Merged

Fix cache access structure and update submodules to the latest #1804

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
00d8a07
cache bug?
Trivo25 Aug 23, 2024
336b2bc
bindings
Trivo25 Aug 23, 2024
0d2f6f5
bindings
Trivo25 Aug 23, 2024
8ab009c
adjust header type
Trivo25 Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/bindings
Open in desktop
Submodule bindings updated 12 files
+1 −1 MINA_COMMIT
+133,951 −133,746 compiled/node_bindings/o1js_node.bc.cjs
+1 −1 compiled/node_bindings/o1js_node.bc.map
+358 −358 compiled/node_bindings/plonk_wasm.cjs
+168 −168 compiled/node_bindings/plonk_wasm.d.cts
+ − compiled/node_bindings/plonk_wasm_bg.wasm
+258 −258 compiled/node_bindings/plonk_wasm_bg.wasm.d.ts
+137 −135 compiled/web_bindings/o1js_web.bc.js
+164 −164 compiled/web_bindings/plonk_wasm.d.ts
+248 −248 compiled/web_bindings/plonk_wasm.js
+ − compiled/web_bindings/plonk_wasm_bg.wasm
+40 −40 compiled/web_bindings/plonk_wasm_bg.wasm.d.ts
2 changes: 1 addition & 1 deletion src/lib/proof-system/prover-keys.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ function parseHeader(
methods: MethodInterface[],
header: SnarkKeyHeader
): CacheHeader {
let hash = Pickles.util.fromMlString(header[1][2][7]);
let hash = Pickles.util.fromMlString(header[1][2][6]);
Copy link
Collaborator

@mitschabaude mitschabaude Aug 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, did the ocaml type change? if yes it would be nice to also change MlSnarkKeysHeader
(the TS type)

Copy link
Member Author

@Trivo25 Trivo25 Aug 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, didnt see that type 8ab009c
MinaProtocol/mina@93d16e2#diff-e97cc66a36b931a3bf0e75bcead151b392188d176a3c71e7408756487b8ff5d1L133

switch (header[0]) {
case KeyType.StepProvingKey:
case KeyType.StepVerificationKey: {
Expand Down
2 changes: 1 addition & 1 deletion src/mina
Open in desktop
Submodule mina updated 779 files