Always test against berkeley in CI #1553
Conversation
.github/workflows/live-tests.yml
Outdated
| timeout-minutes: 45 | ||
| runs-on: ubuntu-latest | ||
| if: github.ref == 'refs/heads/berkeley' || (github.event_name == 'pull_request' && github.base_ref == 'berkeley') | ||
| if: github.ref == 'refs/heads/main' || (github.event_name == 'pull_request') |
There was a problem hiding this comment.
Why condition was changed by removing && github.base_ref == 'main'?
If the goal is to always run the same job then no reason to have any conditions. But if you want to run it on PR against main branch then you need the complete condition.
There was a problem hiding this comment.
Ah ok . I guess the current conditions would run the job on main, and on PRs against main, berkeley and develop? That actually seems fine.
But I can also remove all conditions and run it on all 3 branches
There was a problem hiding this comment.
Without && github.base_ref == 'main' in current state it wil run on any PR
There was a problem hiding this comment.
@shimkiv I don't think so because the intro has this:
pull_request:
branches:
- main
- berkeley
- develop
| @@ -64,29 +38,3 @@ jobs: | |||
| uses: ./.github/actions/live-tests-shared | |||
There was a problem hiding this comment.
Up to you but if we will only have single job here then no reasons to extract steps into shared actions file.
There was a problem hiding this comment.
hm ok, but maybe we need different versions again in the future, so let's leave it as is
This makes CI always test against lightnet built from berkeley, to make sure we stay compatible with devnet