Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Twisted edwards curve operations #1283

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Twisted edwards curve operations #1283

wants to merge 13 commits into from

Conversation

mitschabaude
Copy link
Collaborator

@mitschabaude mitschabaude commented Dec 1, 2023 •
edited
Loading

#985 + #1259 + #1262

everything that should be needed to build powerful new crypto primitives!

@mitschabaude mitschabaude changed the title Merged final gadgets Twisted edwards curve operations Dec 4, 2023
Base automatically changed from feature/foreign-field to main December 4, 2023 16:02
@Trivo25 Trivo25 mentioned this pull request Sep 21, 2024
Open
@querolita querolita changed the base branch from v1 to main November 26, 2024 13:03
@querolita querolita marked this pull request as ready for review November 26, 2024 13:03
@querolita querolita requested review from a team as code owners November 26, 2024 13:03
@querolita querolita requested review from 45930 and querolita November 26, 2024 13:03
@querolita querolita mentioned this pull request Nov 26, 2024
Open
querolita
querolita approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@querolita querolita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After checking the operations proposed here, I am accepting this PR as a basis for EDDSA, but things will likely change in upcoming PRs and will look more like this ECDSA interface.

@querolita querolita self-requested a review December 18, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@45930 45930 Awaiting requested review from 45930 45930 is a code owner automatically assigned from o1-labs/exploration-team

@querolita querolita Awaiting requested review from querolita

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitschabaude @querolita