New v2 bindings layer #336
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trivo25
commented
Feb 18, 2025
| @@ -5,32 +5,26 @@ let testPoseidonKimchiFp = { | |||
| test_vectors: [ | |||
There was a problem hiding this comment.
these didnt change, they are just formatted
Trivo25
commented
Feb 18, 2025
| @@ -0,0 +1,338 @@ | |||
| // NOTE: these leaves are currently backwards compatible with the old encoding format, but the | |||
There was a problem hiding this comment.
there's a few TODOs and nice to haves in here, I propose we get back to them in the future given we target an incremental approach with lots of iterations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
o1-labs/o1js#2032