-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treat devnet and testnet as the same networkId #319
base: main
Are you sure you want to change the base?
Conversation
Are the large diffs related to the primary change? |
Yep! I recompiled the bindings so those autogenerated files are all changed. You can see the same thing here in florian's PR where he made a small change to pickles_bindings.ml https://github.com/o1-labs/o1js-bindings/pull/315/files |
There is literally no change in those files! When only the ocaml code changes, Wasm files don't need updating. The annoying thing is that wasm-bindgen will create slightly shuffled versions of its output each time anything changes, even if it doesn't affect the Wasm source. But the Wasm files could nevertheless be removed from the diff! |
Actually, I just compiled something with an Ocaml-only change and the wasm files didn't change. @hattyhattington17 you sure you had the correct proof-systems / Mina branches checked out when compiling? |
I recloned |
Right it's probably the build environment |
Lol, I looked closer at my screenshot and see the diff now. It's |
I have just reverted the files modifications causing the ugly diff |
Required for o1-labs/o1js#1938