Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat devnet and testnet as the same networkId #319

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

hattyhattington17
Copy link

Required for o1-labs/o1js#1938

@45930
Copy link
Contributor

45930 commented Dec 4, 2024

Are the large diffs related to the primary change?

@hattyhattington17
Copy link
Author

Yep! I recompiled the bindings so those autogenerated files are all changed. You can see the same thing here in florian's PR where he made a small change to pickles_bindings.ml https://github.com/o1-labs/o1js-bindings/pull/315/files

@45930
Copy link
Contributor

45930 commented Dec 4, 2024

image

It's unfortunate since it looks like there is literally no change in those files...

@mitschabaude
Copy link
Collaborator

It's unfortunate since it looks like there is literally no change in those files...

There is literally no change in those files! When only the ocaml code changes, Wasm files don't need updating.

The annoying thing is that wasm-bindgen will create slightly shuffled versions of its output each time anything changes, even if it doesn't affect the Wasm source.

But the Wasm files could nevertheless be removed from the diff!

@mitschabaude
Copy link
Collaborator

Actually, I just compiled something with an Ocaml-only change and the wasm files didn't change. @hattyhattington17 you sure you had the correct proof-systems / Mina branches checked out when compiling?

@hattyhattington17
Copy link
Author

I recloned o1js with submodules, checked out this branch within bindings, and then reran the build so I think I have the right code but tell me if I've missed a step! @Trivo25 mentioned that this might be caused by differences in my build environment? I'm using nix on a mac

@mitschabaude
Copy link
Collaborator

I recloned o1js with submodules, checked out this branch within bindings, and then reran the build so I think I have the right code but tell me if I've missed a step! @Trivo25 mentioned that this might be caused by differences in my build environment? I'm using nix on a mac

Right it's probably the build environment

@45930
Copy link
Contributor

45930 commented Dec 16, 2024

Lol, I looked closer at my screenshot and see the diff now. It's fP and fQ. I'm not sure why different builds would reorder those. Maybe it's non-deterministic?

@querolita
Copy link
Member

I have just reverted the files modifications causing the ugly diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants