Update array handling in Provable.toFields #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ghts match in toFields
…re comparing lengths
…have different lengths
…ror constructor to adhere to convention
mitschabaude
approved these changes
Jul 18, 2024
ymekuria
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses an issue with incorrect array handling in the
provable.toFields()method.Impact
The resulting conversion to fields could be invalid. Certain field elements may be silently ignored.
Changes
toFieldsto make sure thattypeObjandobjhave the same length.objis an array iftypeObjis an array.typeObjandobjhave different lengths.typeObjis an array andobjis not.o1js: o1-labs/o1js#1791