Replace iframes with ResponsiveVideo component
#427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isplay videos in a responsive way
… improve accessibility and responsiveness
…esponsiveVideo component
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ymekuria
approved these changes
Jun 13, 2023
|
So great, Martin, and much cleaner for workflow and result! Excellent work. I updated the Docs wiki with instructions https://github.com/o1-labs/docs2/wiki/Markdown-Syntax#adding-videos-in-docs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current approach for embedding YouTube videos into our content uses the
iframedirectly provided by YouTube's share functionality. While this method offers a straightforward solution for desktop viewers, it falls short regarding mobile-friendliness and proper scaling.In response to these limitations, this Pull Request introduces a new component:
ResponsiveVideo.To utilize this component within a
.mdxfile, the following import statement needs to be added at the top of the file:Subsequently, a responsive
iframecan be rendered with theResponsiveVideocomponent, as demonstrated below:By leveraging this new component, we aim to enhance the viewing experience across different devices, ensuring our embedded YouTube videos scale properly and maintain a mobile-friendly interface.
🔗 Preview Link: https://docs2-git-feat-add-responsive-iframe-minadocs.vercel.app/