-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port over best tip selection algorithm to TypeScript #7
Comments
Indirectly Irresponsible Individual: @bkase |
This cannot be implemented now as |
Changes to incorporate the data is located here: MinaProtocol/mina#12750 |
With the new Berkeley redeployment, this is now actionable and ready to implement 🥳 |
@MartinMinkov should this one fix an issue when Archive-Node-API returned duplicated data for the short period of time because of the chain reorg? |
Yeah, it will fix the duplicate data at the best-tip issue. Currently, the archive node API will return all blocks that are proposed for the best-tip but this change will change the best-tip resolver to choose the "best" block to return for the GraphQL request. Duplicate data should not be happening for blocks below the max block height, however. |
…ta from any block at the best tip This change was made because the issue o1-labs/Archive-Node-API#7 has been resolved, making the temporary fix redundant.
To have a good way of selecting the best tip among multiple blocks at the tip of the network, we need to implement a selection algorithm. We can port over the current algorithm here in TypeScript to do so: https://github.com/MinaProtocol/mina/blob/bff1e117ae4740fa51d12b32736c6c63d7909bd1/src/lib/consensus/proof_of_stake.ml#L2950
The text was updated successfully, but these errors were encountered: