fix(get_at_distance returns the first index): get_at_distance returns the first index no matter the input distance #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…now returns correct index
|
@gambon2010 if (i := self.index_at_distance(d)) < 0:
raise ArithmeticError(
f"Calculated trajectory doesn't reach requested distance {d}"
) |
o-murphy
approved these changes
Jun 17, 2024
o-murphy
added a commit
that referenced
this pull request
Jun 17, 2024
* fix(get_at_distance returns the first index): get_at_distance returns the first index no matter the input distance (#72) * #71 fix(get_at_distance returns the first index): fixed bug, now returns correct index * Update trajectory_data.py --------- Co-authored-by: Chris <christophe@fritschy.net> Co-authored-by: Dmytro Yaroshenko <73843436+o-murphy@users.noreply.github.com> * bumped version to 2.1.0b1 --------- Co-authored-by: gambon2010 <112812216+gambon2010@users.noreply.github.com> Co-authored-by: Chris <christophe@fritschy.net>
Merged
o-murphy
added a commit
that referenced
this pull request
Jul 20, 2024
* fix(get_at_distance returns the first index): get_at_distance returns the first index no matter the input distance (#72) * #71 fix(get_at_distance returns the first index): fixed bug, now returns correct index * Update trajectory_data.py --------- * bumped version to 2.1.0b1 --------- Co-authored-by: gambon2010 <112812216+gambon2010@users.noreply.github.com> Co-authored-by: Chris <christophe@fritschy.net>
o-murphy
added a commit
that referenced
this pull request
Jul 20, 2024
* fix(get_at_distance returns the first index): get_at_distance returns the first index no matter the input distance (#72) * #71 fix(get_at_distance returns the first index): fixed bug, now returns correct index * Update trajectory_data.py --------- Co-authored-by: Chris <christophe@fritschy.net> Co-authored-by: Dmytro Yaroshenko <73843436+o-murphy@users.noreply.github.com> * bumped version to 2.1.0b1 * 2.1.0b1 (#73) (#76) * fix(get_at_distance returns the first index): get_at_distance returns the first index no matter the input distance (#72) * #71 fix(get_at_distance returns the first index): fixed bug, now returns correct index * Update trajectory_data.py --------- * bumped version to 2.0.2 --------- Co-authored-by: gambon2010 <112812216+gambon2010@users.noreply.github.com> Co-authored-by: Chris <christophe@fritschy.net> * removed cli entry and experimental .toml-based profiles support --------- Co-authored-by: gambon2010 <112812216+gambon2010@users.noreply.github.com> Co-authored-by: Chris <christophe@fritschy.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way the assignment and comparison are combined leads to an incorrect evaluation.
The line is trying to both assign and compare in a single statement, which results in incorrect logic. The assignment should be done separately from the comparison.