Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature windows build fix #9

Merged
merged 4 commits into from
Sep 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions .github/workflows/windows.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
name: Build and upload NZBGet for Windows

on:
push:
branches:
- feature-*
- develop
- master

jobs:
build:
runs-on: [self-hosted, windows]

steps:

- name: Checkout
uses: actions/checkout@v3

- name: Build
run: |
.\windows\build-nzbget-vs22.bat

- name: Upload build artifacts
uses: actions/upload-artifact@v3
with:
name: nzbget-installers
path: C:\nzbget\build\output\*.exe
retention-days: 5
4 changes: 4 additions & 0 deletions daemon/connect/TlsSocket.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,11 @@ void TlsSocket::Final()

#ifdef HAVE_OPENSSL
#ifndef LIBRESSL_VERSION_NUMBER
#if OPENSSL_VERSION_NUMBER < 0x30000000L
FIPS_mode_set(0);
#else
EVP_default_properties_enable_fips(NULL, 0);
#endif
#endif
#ifdef NEED_CRYPTO_LOCKING
CRYPTO_set_locking_callback(nullptr);
Expand Down
2 changes: 1 addition & 1 deletion daemon/main/nzbget.h
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ compiled */

#ifndef DISABLE_GZIP
// Static linking to zlib library
#define ZLIB_WINAPI
//#define ZLIB_WINAPI
#endif

/* Suppress warnings */
Expand Down
2 changes: 1 addition & 1 deletion daemon/util/FileSystem.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1013,7 +1013,7 @@ CString FileSystem::MakeExtendedPath(const char* path, bool force)
else
{
// local path
longpath.Format("\\\\?\\%s", canonicalPath);
longpath.Format("\\\\?\\%s", std::move(canonicalPath));
}
return *longpath;
}
Expand Down
2 changes: 1 addition & 1 deletion daemon/util/Script.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,7 @@ void ScriptController::StartProcess(int* pipein, int* pipeout)
}
if (wcslen(wideWorkingDir) > 260)
{
PrintMessage(Message::mkError, "Could not build short path for %s", workingDir);
PrintMessage(Message::mkError, "Could not build short path for %s", std::move(workingDir));
}
CloseHandle(readPipe);
CloseHandle(readProcPipe);
Expand Down
Loading