Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: segmentation fault with HealthCheck=None with ParCheck=Force #475

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Fix: segmentation fault with HealthCheck=None with ParCheck=Force #475

merged 1 commit into from
Dec 23, 2024

Conversation

dnzbk
Copy link
Collaborator

@dnzbk dnzbk commented Dec 23, 2024

Description

  • fixed: HealthCheck=None with ParCheck=Force can cause Segmentation Fault on unhealthy downloads
  • added additional checks for nullptr

Testing

  • Windows 11

@dnzbk dnzbk requested a review from phnzb December 23, 2024 06:29
@dnzbk dnzbk linked an issue Dec 23, 2024 that may be closed by this pull request
HealthCheck=None with ParCheck=Force can cause Segmentation Fault on unhealthy downloads #474
Closed
1 task
@dnzbk dnzbk merged commit e5cbe71 into develop Dec 23, 2024
3 checks passed
@dnzbk dnzbk deleted the fix/seg-fault branch December 23, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phnzb phnzb phnzb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HealthCheck=None with ParCheck=Force can cause Segmentation Fault on unhealthy downloads
2 participants
@dnzbk @phnzb