Par2-turbo integration #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
luckedea
approved these changes
Nov 6, 2024
|
seems to be really faster but in the webpage I dont see now while it is being repaired a status information, e.g. time remaining... |
beertje44
pushed a commit
to beertje44/nzbget
that referenced
this pull request
Dec 4, 2024
## Description - replaced the Par2 library with Par2-turbo which provides faster file recovery on x86/ARM platforms ## Lib changes - switched from Par2 to Par2-turbo - removed Par2 source files from the repo
sbraz
reviewed
Dec 7, 2024
| FetchContent_Declare( | ||
| par2-turbo | ||
| GIT_REPOSITORY https://github.com/nzbgetcom/par2cmdline-turbo.git | ||
| GIT_TAG nzbget |
There was a problem hiding this comment.
Why specify a branch that is likely to get updated instead of a tag? Won't it break nzbget builds if breaking changes are published to the nzbget branch of par2cmdline-turbo?
There was a problem hiding this comment.
It is a tag already https://github.com/nzbgetcom/nzbget/blob/develop/cmake%2Fpar2-turbo.cmake#L31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Lib changes
Testing