Feature/article read chunk size (#52)

* Added ArticleReadChunkSize config option which allows to adjust the buffer size for customization on different platforms, which can lead to increased performance.
nzbgetcom · Nov 8, 2023 · 1aa42f2 · 1aa42f2
1 parent 885058f
commit 1aa42f2
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 1 deletion.
diff --git a/daemon/main/Options.cpp b/daemon/main/Options.cpp
@@ -68,6 +68,7 @@ static const char* OPTION_CERTSTORE				= "CertStore";
 static const char* OPTION_CERTCHECK				= "CertCheck";
 static const char* OPTION_AUTHORIZEDIP			= "AuthorizedIP";
 static const char* OPTION_ARTICLETIMEOUT		= "ArticleTimeout";
+static const char* OPTION_ARTICLEREADCHUNKSIZE	= "ArticleReadChunkSize";
 static const char* OPTION_URLTIMEOUT			= "UrlTimeout";
 static const char* OPTION_REMOTETIMEOUT			= "RemoteTimeout";
 static const char* OPTION_FLUSHQUEUE			= "FlushQueue";
@@ -447,6 +448,7 @@ void Options::InitDefaults()
 	SetOption(OPTION_CERTCHECK, "no");
 	SetOption(OPTION_AUTHORIZEDIP, "");
 	SetOption(OPTION_ARTICLETIMEOUT, "60");
+	SetOption(OPTION_ARTICLEREADCHUNKSIZE, "4");
 	SetOption(OPTION_URLTIMEOUT, "60");
 	SetOption(OPTION_REMOTETIMEOUT, "90");
 	SetOption(OPTION_FLUSHQUEUE, "yes");
@@ -694,6 +696,7 @@ void Options::InitOptions()
 
 	m_downloadRate			= ParseIntValue(OPTION_DOWNLOADRATE, 10) * 1024;
 	m_articleTimeout		= ParseIntValue(OPTION_ARTICLETIMEOUT, 10);
+	m_articleReadChunkSize  = ParseIntValue(OPTION_ARTICLEREADCHUNKSIZE, 10) * 1024;
 	m_urlTimeout			= ParseIntValue(OPTION_URLTIMEOUT, 10);
 	m_remoteTimeout			= ParseIntValue(OPTION_REMOTETIMEOUT, 10);
 	m_articleRetries		= ParseIntValue(OPTION_ARTICLERETRIES, 10);

diff --git a/daemon/main/Options.h b/daemon/main/Options.h
@@ -210,6 +210,7 @@ class Options
 	EMessageTarget GetDebugTarget() const { return m_debugTarget; }
 	EMessageTarget GetDetailTarget() const { return m_detailTarget; }
 	int GetArticleTimeout() { return m_articleTimeout; }
+	int GetArticleReadChunkSize() { return m_articleReadChunkSize; }
 	int GetUrlTimeout() { return m_urlTimeout; }
 	int GetRemoteTimeout() { return m_remoteTimeout; }
 	bool GetRawArticle() { return m_rawArticle; };
@@ -345,6 +346,7 @@ class Options
 	bool m_rawArticle = false;
 	bool m_nzbLog = false;
 	int m_articleTimeout = 0;
+	int m_articleReadChunkSize = 4;
 	int m_urlTimeout = 0;
 	int m_remoteTimeout = 0;
 	bool m_appendCategoryDir = false;

diff --git a/daemon/nntp/ArticleDownloader.cpp b/daemon/nntp/ArticleDownloader.cpp
@@ -335,7 +335,7 @@ ArticleDownloader::EStatus ArticleDownloader::Download()
 	m_decoder.SetRawMode(g_Options->GetRawArticle());
 
 	status = adRunning;
-	CharBuffer lineBuf(1024*4);
+	CharBuffer lineBuf(g_Options->GetArticleReadChunkSize());
 
 	while (!IsStopped() && !m_decoder.GetEof())
 	{

diff --git a/nzbget.conf b/nzbget.conf
@@ -1004,6 +1004,9 @@ ArticleInterval=10
 # Connection timeout for article downloading (seconds).
 ArticleTimeout=60
 
+# Chunk size when reading data from the news server (kilobytes).
+ArticleReadChunkSize=4
+
 # Number of download attempts for URL fetching (0-99).
 #
 # If fetching of nzb-file via URL or fetching of RSS feed fails another